Add a test for non-ascii char input escaped with C-v#835
Merged
Conversation
tompng
force-pushed
the
non_ascii_escape_test
branch
2 times, most recently
from
2ec6648 to
5d6f891
Compare
tompng
commented
Jul 5, 2025
| sync | ||
| @pty_input.write(str) | ||
| try_sync | ||
| end |
Member
Author
There was a problem hiding this comment.
Ideally, I think changing yamatanooroti's write to not do this conversion is better.
But if we do that, there will be no way to input meta key to yamatanooroti-windows and yamatanooroti-vterm in a common way.
C-v are inserted by terminal emulator's configuration. In macOS Terminal.app, enabling "Escape non-ASCII input with Control-V" configuration will make the input "\xE3\x81\x82" to "\x16\xE3\x16\x81\x16\x82".
tompng
force-pushed
the
non_ascii_escape_test
branch
from
5d6f891 to
8fe8591
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a mystery of
0x16in Reline. There is no test and no source code comment.0x16seems to be inserted in some case (what case?) in some way (how?) but nobody knows how and why.It turned out that this is 0x16 came from a configuration of terminal emulator
Escape non-ASCII input with Control-V(ohmyzsh/ohmyzsh#7412)
With this configuration, every non-ascii byte will be escaped with
\C-vNow we can add a test and a comment